Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Day Zero study #1279

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Remove Day Zero study #1279

merged 1 commit into from
Dec 12, 2024

Conversation

DJAndries
Copy link
Collaborator

No description provided.

@DJAndries DJAndries requested a review from a team as a code owner December 9, 2024 20:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1279.
    Android: Set the command line to --variations-pr=1279 in debug menu, restart the browser.
    iOS: Set Variations PR to 1279 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1279@19dcb11134fb932c85da67138a3a42af9db35631
Uploaded Mon, 09 Dec 2024 20:44:56 GMT
PR commit 1b2f9a0
Base commit d381089
Merge commit 19dcb11
Serial number 01991f1d5d5bc3a61b5126b1cea948c3

kjozwiak
kjozwiak approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into main/production has been approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 7970395 Dec 12, 2024
6 checks passed
@kjozwiak kjozwiak deleted the remove-day-zero branch December 12, 2024 15:26
@deeppandya deeppandya mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DJAndries @kjozwiak