-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable BraveWebcompatExceptionsService in Nightly #1180
Conversation
✅ Test Seed Generated SuccessfullyTo apply the test seed:
Seed Details
|
|
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|
Nightly
- min_version
condition not met
Brave | 1.70.65 Chromium: 128.0.6613.27 (Official Build) nightly (64-bit)
-- | --
Revision | 8bf2d6fd36dc289a5918c6c06969c161d81717dc
OS | Windows 11 Version 23H2 (Build 22631.4037)
- launched/re-launched
1.70.65 Chromium: 128.0.6613.27
usingbrave.exe --enable-logging=stderr --variations-pr=1180
- ensured that
pull/1180@58b8428788ce101b28afc318eea84c967bdf411f
viabrave://version
underActive variations
- ensured that
BraveWebcompatExceptionsServiceStudy:Enabled
was not being displayed viabrave://version
- visited https://browserleaks.com/javascript and clicked on the shields panel
- ensured there's no
Advanced
controls/switches re: being able to disable fingerprintable API's.
Example |
Example |
---|---|
|
Example |
Example |
Example |
---|---|---|
Nightly
- min_version
condition not met
Brave | 1.70.65 Chromium: 128.0.6613.27 (Official Build) canary (64-bit)
--- | ---
Revision | 8bf2d6fd36dc289a5918c6c06969c161d81717dc
OS | Android 15; Build/AP31.240617.010; 35; REL
- launched
1.70.65 Chromium: 128.0.6613.27
- visited https://www.nperf.com/en/ and ensured that the website wasn't working/speed test wasn't initiated
- applied
--variations-pr=1180
via theQA Developer
settings and restarted1.70.65 Chromium: 128.0.6613.27
- ensured that
pull/1180@58b8428788ce101b28afc318eea84c967bdf411f
viabrave://version
underActive variations
- ensured that
BraveWebcompatExceptionsServiceStudy:Enabled
was not being displayed inbrave://version
- visited https://www.nperf.com/en/ and ensured that the website wasn't working/speed test wasn't initiated
Example |
Example |
Example |
---|---|---|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift into production
approved after deliberating with @brave/uplift-approvers 👍 QA has verified the PR on Nightly
as per #1180 (comment) & #1180 (comment). QA has also verified the feature via brave/brave-browser#37074
Resolves #1179