Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable WebcompatExceptionsService in Release #1194

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Enable WebcompatExceptionsService in Release #1194

merged 2 commits into from
Aug 23, 2024

Conversation

arthuredelstein
Copy link
Collaborator

@arthuredelstein arthuredelstein commented Aug 21, 2024

Resolves #1193

@arthuredelstein arthuredelstein requested a review from a team as a code owner August 21, 2024 18:52
Copy link
Contributor

github-actions bot commented Aug 21, 2024

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1194.
    Android: Set the command line to --variations-pr=1194 in debug menu, restart the browser.
    iOS: Set Variations PR to 1194 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1194@255b12f7253e14f997228b2f1e6284477d5195e6
Uploaded Fri, 23 Aug 2024 16:39:06 GMT
PR commit 1f22866
Base commit a86855b
Merge commit 255b12f
Serial number 91ae024eca07d3011cbc02b4c5f8a92f

@kjozwiak
Copy link
Member

Quick Note: Both Nightly & BETA have already been checked/verified via #1180 (comment), #1180 (comment), #1190 (comment) & #1190 (comment). QA has also verified the feature via 1.69.x as per brave/brave-browser#37074 (comment), brave/brave-browser#37074 (comment), brave/brave-browser#37074 (comment) & brave/brave-browser#37074 (comment).

With the above, I'll just run through a quick spot check to ensure that the feature is being enabled/functioning via Griffin.

@kjozwiak
Copy link
Member

Windows verification(s):

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.69.153 Chromium: 128.0.6613.85 (Official Build) (64-bit)
-- | --
Revision | a69e96756922f88cbce3482971d70cfd1ee6f872
OS | Windows 11 Version 23H2 (Build 22631.4037)

Release - BraveWebcompatExceptionsServiceReleaseStudy:Enabled

Example Example Example
image image image

Release - BraveWebcompatExceptionsServiceReleaseStudy:Default

Example Example Example
image image image

Release - doesn't meet min_version requirement

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.69.149 Chromium: 128.0.6613.40 (Official Build) (64-bit)
-- | --
Revision | a6a137ec4f7f0b30e1d3940dbfcde72c32d35baa
OS | Windows 11 Version 23H2 (Build 22631.4037)
  • launched/re-launched 1.69.149 Chromium: 128.0.6613.40 using brave.exe --enable-logging=stderr --variations-pr=1194
  • ensured that pull/1194@255b12f7253e14f997228b2f1e6284477d5195e6 via brave://version under Active variations
  • ensured that BraveWebcompatExceptionsServiceReleaseStudy doesn't appear/listed under brave://version

image

@kjozwiak
Copy link
Member

Android verification(s):

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Brave | 1.69.153 Chromium: 128.0.6613.85 (Official Build) (64-bit)
--- | ---
Revision | a69e96756922f88cbce3482971d70cfd1ee6f872
OS | Android 15; Build/AP31.240617.015; 35; REL

Release - BraveWebcompatExceptionsServiceReleaseStudy:Enabled

  • launched 1.69.153 Chromium: 128.0.6613.85
  • applied --variations-pr=1190 via the QA Developer settings and restarted 1.69.153 Chromium: 128.0.6613.85
  • ensured that pull/1194@255b12f7253e14f997228b2f1e6284477d5195e6 via brave://version under Active variations
  • ensured that BraveWebcompatExceptionsServiceStudy:Enabled via brave://version
  • visited https://www.nperf.com/en/ and ensured the speedtest/website was working without any issues/failures
Example Example
Screenshot_20240823-162010 Screenshot_20240823-162058

Release - BraveWebcompatExceptionsServiceReleaseStudy:Default

  • launched 1.69.153 Chromium: 128.0.6613.85
  • applied --variations-pr=1190 via the QA Developer settings and restarted 1.69.153 Chromium: 128.0.6613.85
  • ensured that pull/1194@255b12f7253e14f997228b2f1e6284477d5195e6 via brave://version under Active variations
  • ensured that BraveWebcompatExceptionsServiceStudy:Default via brave://version
  • visited https://www.nperf.com/en and ensured that it wasn't working/displayed a Connection to server could not be established. You can try again in a few seconds. error message.
Example Example
Screenshot_20240823-161429 Screenshot_20240823-161738

Release - doesn't meet min_version requirement

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.69.149 Chromium: 128.0.6613.40 (Official Build) (64-bit)
--- | ---
Revision | a6a137ec4f7f0b30e1d3940dbfcde72c32d35baa
OS | Android 15; Build/AP31.240617.015; 35; REL
  • launched/re-launched 1.69.149 Chromium: 128.0.6613.40
  • applied --variations-pr=1190 via the QA Developer settings and restarted 1.69.149 Chromium: 128.0.6613.40
  • ensured that pull/1194@255b12f7253e14f997228b2f1e6284477d5195e6 via brave://version under Active variations
  • ensured that BraveWebcompatExceptionsServiceReleaseStudy doesn't appear/listed under brave://version

Screenshot_20240823-162615

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Release on both Desktop & Android as per #1194 (comment) & #1194 (comment). The above has already been enabled at 100% for both Nightly & BETA and has been verified/tested by QA via 1.69.x as mentioned via #1194 (comment).

@kjozwiak kjozwiak added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit 4d07ec6 Aug 23, 2024
7 checks passed
@kjozwiak kjozwiak deleted the issues/1193 branch August 23, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable WebcompatExceptionsService in Release
3 participants