-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable WebcompatExceptionsService in Release #1194
Conversation
✅ Test Seed Generated SuccessfullyTo apply the test seed:
Seed Details
|
With the above, I'll just run through a quick spot check to ensure that the feature is being enabled/functioning via Griffin. |
|
Example |
Example |
Example |
---|---|---|
Release
- BraveWebcompatExceptionsServiceReleaseStudy:Default
- launched/re-launched
1.69.153 Chromium: 128.0.6613.85
usingbrave.exe --enable-logging=stderr --variations-pr=1194
- ensured that
pull/1194@255b12f7253e14f997228b2f1e6284477d5195e6
viabrave://version
underActive variations
- ensured that
BraveWebcompatExceptionsServiceReleaseStudy:Default
viabrave://version
- visited https://maps.gsi.go.jp/index_3d.html?z=16&lat=35.653225&lon=139.73539700000003&pxsize=1024&ls=std#&cpx=-54.107&cpy=162.515&cpz=99.300&cux=-0.518&cuy=0.245&cuz=0.820&ctx=1.324&cty=20.508&ctz=33.599&a=1&b=0&dd=0 and ensured that the
spikes
are being displayed - visited https://www.nperf.com/en and ensured that it wasn't working/displayed a
Connection to server could not be established. You can try again in a few seconds.
error message.
Example |
Example |
Example |
---|---|---|
Release
- doesn't meet min_version
requirement
Verification PASSED on Win 11 x64
using the following build(s):
Brave | 1.69.149 Chromium: 128.0.6613.40 (Official Build) (64-bit)
-- | --
Revision | a6a137ec4f7f0b30e1d3940dbfcde72c32d35baa
OS | Windows 11 Version 23H2 (Build 22631.4037)
- launched/re-launched
1.69.149 Chromium: 128.0.6613.40
usingbrave.exe --enable-logging=stderr --variations-pr=1194
- ensured that
pull/1194@255b12f7253e14f997228b2f1e6284477d5195e6
viabrave://version
underActive variations
- ensured that
BraveWebcompatExceptionsServiceReleaseStudy
doesn't appear/listed underbrave://version
|
Example |
Example |
---|---|
Release
- BraveWebcompatExceptionsServiceReleaseStudy:Default
- launched
1.69.153 Chromium: 128.0.6613.85
- applied
--variations-pr=1190
via theQA Developer
settings and restarted1.69.153 Chromium: 128.0.6613.85
- ensured that
pull/1194@255b12f7253e14f997228b2f1e6284477d5195e6
viabrave://version
underActive variations
- ensured that
BraveWebcompatExceptionsServiceStudy:Default
viabrave://version
- visited https://www.nperf.com/en and ensured that it wasn't working/displayed a
Connection to server could not be established. You can try again in a few seconds.
error message.
Example |
Example |
---|---|
Release
- doesn't meet min_version
requirement
Verification PASSED on Win 11 x64
using the following build(s):
Brave | 1.69.149 Chromium: 128.0.6613.40 (Official Build) (64-bit)
--- | ---
Revision | a6a137ec4f7f0b30e1d3940dbfcde72c32d35baa
OS | Android 15; Build/AP31.240617.015; 35; REL
- launched/re-launched
1.69.149 Chromium: 128.0.6613.40
- applied
--variations-pr=1190
via theQA Developer
settings and restarted1.69.149 Chromium: 128.0.6613.40
- ensured that
pull/1194@255b12f7253e14f997228b2f1e6284477d5195e6
viabrave://version
underActive variations
- ensured that
BraveWebcompatExceptionsServiceReleaseStudy
doesn't appear/listed underbrave://version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift into production
approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Release
on both Desktop
& Android
as per #1194 (comment) & #1194 (comment). The above has already been enabled at 100%
for both Nightly
& BETA
and has been verified/tested by QA via 1.69.x
as mentioned via #1194 (comment).
Resolves #1193