Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial l10n for VPN widget. #26938

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Partial l10n for VPN widget. #26938

merged 1 commit into from
Dec 10, 2024

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Dec 9, 2024

Resolves brave/brave-browser#42769

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin self-assigned this Dec 9, 2024
@mkarolin mkarolin requested a review from a team as a code owner December 9, 2024 19:38
Copy link
Contributor

github-actions bot commented Dec 9, 2024

[puLL-Merge] - brave/brave-core@26938

Description

This PR updates and adds translations for various languages related to Brave VPN and other features. The changes include adding new strings and modifying existing ones across multiple language files.

Changes

Changes

  1. components/resources/brave_vpn_strings.grdp:

    • Minor whitespace changes
  2. Multiple language files (*.xtb):

    • Added translations for "Brave VPN" and "Change"
    • Some languages received additional translations for:
      • "Protect every app & your entire device"
      • "Extra online privacy & security."
      • "Start free trial"
  3. Specific language changes:

    • German (de.xtb), Spanish (es-419.xtb), French (fr.xtb), Japanese (ja.xtb), Korean (ko.xtb), Portuguese (pt-BR.xtb), Russian (ru.xtb), Thai (th.xtb), Turkish (tr.xtb), and Vietnamese (vi.xtb) received more comprehensive updates related to Brave VPN features.
sequenceDiagram
    participant Dev as Developer
    participant Repo as Brave Core Repository
    participant Lang as Language Files

    Dev->>Repo: Update brave_vpn_strings.grdp
    Dev->>Lang: Add "Brave VPN" translation
    Dev->>Lang: Add "Change" translation
    Dev->>Lang: Add VPN feature translations (selected languages)
    Repo-->>Dev: Confirm changes
    Lang-->>Dev: Confirm translations added
Loading

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@mkarolin mkarolin merged commit f6982f7 into master Dec 10, 2024
19 checks passed
@mkarolin mkarolin deleted the maxk-vpn-card-l10n branch December 10, 2024 18:29
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 10, 2024
brave-builds added a commit that referenced this pull request Dec 10, 2024
brave-builds added a commit that referenced this pull request Dec 10, 2024
kjozwiak pushed a commit that referenced this pull request Dec 11, 2024
kjozwiak pushed a commit that referenced this pull request Dec 11, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.91

mkarolin pushed a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update l10n for VPN NTP card.
3 participants