Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Variations Seed Type - Null when trying to restore production Griffin seed after using pr seed flag #39767

Closed
3 of 6 tasks
stephendonner opened this issue Jul 15, 2024 · 5 comments · Fixed by brave/brave-core#24670

Comments

@stephendonner
Copy link

stephendonner commented Jul 15, 2024

Description

Getting Variations Seed Type - Null when trying to restore production Griffin seed after using pr seed flag

This was found whilst testing the 3rd case in #39689

Steps to reproduce

  1. install 1.69.108
  2. launch Brave using --variations-pr=1123
  3. restarted Brave
  4. wait 10+ seconds (preferably more, accounting for slow connections/transfers)
  5. restart Brave
  6. open brave://version and confirm the special seed details from Simplify variations pull requests testing process #39689 (comment)
  7. now, remove the --variations-pr=1123 parameter
  8. relaunch Brave
  9. wait 10+ seconds (preferably more)
  10. open brave://version`

Actual result

In brave://version, it shows:

Variations Seed Type is Null

image

Expected result

Since the production Griffin seed was restored, there should be the usual litany of Active Variations studies listed, instead:

image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave | 1.69.108 Chromium: 127.0.6533.43 (Official Build) nightly (64-bit)
-- | --
Revision | d5e7dd710a027aa197965d0603ec587791be032e
OS | Windows 10 Version 22H2 (Build 19045.4651)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc @goodov @brave/qa-team @rebron

@goodov
Copy link
Member

goodov commented Jul 16, 2024

This is because of brave/brave-core#24550

@kjozwiak
Copy link
Member

The above requires 1.68.124 or higher for 1.68.x verification 👍 @brave/qa-team this will get verified/checked while running through #39689 using the template from brave/brave-core#24604 (comment). For example, the above is covered in the following tests via brave/brave-core#24604 (comment):

  • Desktop --> Test Case #4 - ensuring https://variations.brave.com/seed is being restored - PASSED
  • Android --> Test Case #3 - ensuring https://variations.brave.com/seed is being restored - PASSED

@stephendonner
Copy link
Author

stephendonner commented Jul 18, 2024

As @kjozwiak mentions in #39767 (comment), this was tested and verified in #39689 (comment), specifically Test Case #4 - ensuring https://variations.brave.com/seed is being restored

@btlechowski
Copy link

Verified with

Brave 1.68.124 Chromium: 127.0.6533.57 (Official Build) (64-bit)
Revision d048917c488542dc56e67059011b2cf9d6043bb9
OS Linux

Verified in #39689 (comment)

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.68.124 Chromium: 127.0.6533.57 (Official Build) (64-bit)
-- | --
Revision | d048917c488542dc56e67059011b2cf9d6043bb9
OS | Windows 11 Version 23H2 (Build 22631.3880)

Verified via #39689 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment