Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #24550 from brave/cr127-followup-disable-s… #24670

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

goodov
Copy link
Member

@goodov goodov commented Jul 16, 2024

Restore variations apply after restarts. MetricsService should not be stubbed entirely.

Resolves brave/brave-browser#39767

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

…ecurity-privacy-feature-flags"

This reverts commit c218ba2, reversing
changes made to 7785f3c.
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Jul 16, 2024
@goodov goodov marked this pull request as ready for review July 16, 2024 10:31
@goodov goodov requested a review from a team as a code owner July 16, 2024 10:31
@goodov goodov enabled auto-merge (squash) July 16, 2024 10:52
@goodov goodov merged commit 728a82a into master Jul 16, 2024
18 checks passed
@goodov goodov deleted the revert-issues/39615 branch July 16, 2024 12:51
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jul 16, 2024
brave-builds added a commit that referenced this pull request Jul 16, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Jul 16, 2024

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.69.111 Chromium: 127.0.6533.43 (Official Build) nightly (64-bit)
-- | --
Revision | 4d39f6a867ca388981fcb24fb2bf4007ae913651
OS | Windows 11 Version 23H2 (Build 22631.3880)

Please see #24604 (comment) for verification notes. Specifically Test Case #3 which worked without any issues. As per the original issue via brave/brave-browser#39767, the end result was Null via brave://version which isn't occurring anymore.

kjozwiak pushed a commit that referenced this pull request Jul 17, 2024
…… (uplift to 1.68.x) (#24672)

Uplift of #24670 (squashed) to beta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Variations Seed Type - Null when trying to restore production Griffin seed after using pr seed flag
3 participants