Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore upstream variations/shutdown tests #39773

Closed
goodov opened this issue Jul 16, 2024 · 1 comment · Fixed by brave/brave-core#24671
Closed

Restore upstream variations/shutdown tests #39773

goodov opened this issue Jul 16, 2024 · 1 comment · Fixed by brave/brave-core#24671
Assignees
@goodov
Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Milestone
1.70.x - Release

Comments

@goodov
Copy link
Member

goodov commented Jul 16, 2024 •
edited
Loading

Description

We recently disabled MetricsService [1] which led to incorrect shutdown handling and broken variations after 5th restart [2]. There are some upstream tests that could've prevented this. We need to re-enable/fix those.

  1. Disable features flagged by security/privacy team brave-core#24550
  2. Getting Variations Seed Type - Null when trying to restore production Griffin seed after using pr seed flag #39767
@goodov goodov mentioned this issue Jul 16, 2024
Merged
24 tasks
@goodov goodov self-assigned this Jul 16, 2024
@atuchin-m
Copy link
Contributor

A related perf issue: #39864

@brave-builds brave-builds added this to the 1.70.x - Nightly milestone Jul 23, 2024
@goodov goodov mentioned this issue Jul 23, 2024
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goodov goodov

Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.70.x - Release
Development

Successfully merging a pull request may close this issue.

Enable important Chromium browser lifetime tests brave/brave-core
3 participants
@goodov @brave-builds @atuchin-m