chore: fix preact usages across application #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsgoulart
reviewed
Jan 10, 2024
packages/form-js-editor/src/features/render-injection/slot-fill/SlotFillRoot.js
Outdated
Show resolved
Hide resolved
packages/form-js-viewer/src/render/hooks/useCleanupMultiSelectValues.js
Outdated
Show resolved
Hide resolved
Related to hto#444
Related to hto#444
Related to hto#444
Skaiir
force-pushed
the
fix-form-reactivity
branch
from
704b5b7 to
293a941
Compare
vsgoulart
approved these changes
Jan 11, 2024
| @@ -4,10 +4,10 @@ import { | |||
| } from 'preact/hooks'; | |||
|
|
|||
|
|
|||
| export default function usePrevious(value) { | |||
| const ref = useRef(); | |||
| export default function usePrevious(value, defaultValue = null) { | |||
There was a problem hiding this comment.
Kind of unrelated, but I think the implementation of this component is wrong, no?
It's not a reactive hook, here's a correct implementation of one
There was a problem hiding this comment.
Yeah it's probably doing more re-renders than necessary. I'll send a PR later to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/camunda/team-hto/issues/444
This is only the first part of the changes. There's one big misuse left but it's super core and might take a bit for me to diagnose completely. But I've reduced down the warnings from 35ish to 1 which is progress.
I've still got another part of this on a local branch which is to merge the properties panel render tree with that of the rest of the editor, but still need a little bit of debugging for that one. Won't be long though. But let's merge as we go along.