Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix internal usePrevious hooks #981

Closed
wants to merge 1 commit into from
Closed

Conversation

Skaiir
Copy link
Contributor

@Skaiir Skaiir commented Jan 11, 2024

Related to #972 (comment)

@Skaiir Skaiir requested a review from vsgoulart January 11, 2024 12:03
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 11, 2024
Copy link
Contributor

@douglasbouttell-camunda douglasbouttell-camunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsgoulart vsgoulart changed the title schore: fix internal usePrevious hooks chore: fix internal usePrevious hooks Jan 11, 2024
@Skaiir
Copy link
Contributor Author

Skaiir commented Jan 16, 2024

Actually there's an issue here, we do depend on making the check in a non-reactive manner some places. Need to investigate, will shelve for now.

@Skaiir Skaiir marked this pull request as draft January 16, 2024 03:00
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Jan 16, 2024
@Skaiir Skaiir deleted the branch master February 5, 2024 10:53
@Skaiir Skaiir closed this Feb 5, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants