feat(a11y): fields announce their descriptions and labels properly #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Include all description blocks in `aria-describedby`. * Add `required` property to inputs that can be required. * Add `aria-invalid` property to input which have validation errors. * Do not announce the asterisk/star which denotes a required field. * Have components generate their own error ID. * Remove confusing use of `id` in Label. It now has an `id` and an `htmlFor` prop. * Update groups `aria-labelledby` to point to an actual label.
|
@douglasbouttell-camunda is this PR ready for review? |
bpmn-io-tasks
bot
added
needs review
vsgoulart
approved these changes
Feb 15, 2024
vsgoulart
pushed a commit
that referenced
this pull request
Feb 20, 2024
…1043) * Include all description blocks in `aria-describedby`. * Add `required` property to inputs that can be required. * Add `aria-invalid` property to input which have validation errors. * Do not announce the asterisk/star which denotes a required field. * Have components generate their own error ID. * Remove confusing use of `id` in Label. It now has an `id` and an `htmlFor` prop. * Update groups `aria-labelledby` to point to an actual label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a whole bunch of elements so they announce themselves properly in a screenreader.
aria-describedby.requiredproperty to inputs that can be required.aria-invalidproperty to input which have validation errors.idin Label. It now has anidand anhtmlForprop.aria-labelledbyto point to an actual label.Closes #1042
form-jselement or visually changes an existing component.