feat(popup-menu): add ability to refresh without reopening #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
reviewed
Feb 21, 2024
| /** | ||
| * Refresh the popup menu entries without changing the target or position. | ||
| */ | ||
| PopupMenu.prototype.refresh = function() { |
There was a problem hiding this comment.
I wonder if we can we consolidate existing behavior, i.e. call refresh here?
Looks good otherwise.
There was a problem hiding this comment.
Makes sense, I'll add that.
nikku
approved these changes
Feb 21, 2024
|
Will be released via #861. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
refreshmethod to the popup menu. Allows updating the popup menu's entries without having to reopen it.Closes #804