-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a refresh
function to the popupMenu
object
#804
Comments
refresh
function to the popMenu
objectrefresh
function to the popupMenu
object
If I understand you correctly, the required feature is to be able to reload the content of the popup menu without reopening. Still, I can imagine that even such expansion of the API may appear to be too limited soon. If a user requests additional entries which are loaded asynchronously, they may expect some kind of loader/spinner for which there is no place in the current, synchronous API. Perhaps we need to have a popup menu which could receive entries asynchronously? Or a way to hook up into what component is displayed? |
Correct :)
My gut feeling is that this depends on the direction that we want to take in the future; right now the async business logic to select / fetch / import new templates is handled by different components of the web-modeler, meaning that when we set new templates in the |
To me this sounds like a reasonable request. We already use such functionality internally. |
@marcellobarile Maybe you can take inspiration from the built-in refresh functionality. That could shorten the hack you mentioned. |
There is no capacity in this iteration, we leave it in |
1 similar comment
There is no capacity in this iteration, we leave it in |
@barmac You are assigned to this issue. Are you planning to work on it anytime soon? |
@barmac As discussed, I will take over this issue. |
Closed by #860. |
Is your feature request related to a problem? Please describe.
With https://github.com/camunda/web-modeler/issues/6066 we are adding to the web-modeler the capability to import element templates from the marketplace;
once this is done via a pop-over dialog, the user should go back to the diagram following a non-interrupting UX; the just imported element templates should be listed in the element templates list while it's opened.
Describe the solution you'd like
We are
hacking
thepopupMenu
in the web-modeler by programmatically closing and re-opening it.This solves the issue because it implicitly forces a new rendering.
This could be avoided if the
popupMenu
was exposing arefresh
method that computes and renders the entities list from scratch.In the alternative, the list in the UI could be internally refreshed as soon as new templates are set via the
elementTemplatesLoader
.Additional context
First, we update the list of templates by calling
elementTemplatesLoader.setTemplates
as soon as we have imported new element templates.Secondly, this is the
hacky
solution implemented in the web-modeler to "propagate" the change also to the UI (without having to go away from the diagram, or unselecting and reselecting the element and other actions that might create friction during the modelling):The text was updated successfully, but these errors were encountered: