Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to diagram-js@14 #2097

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Update to diagram-js@14 #2097

merged 1 commit into from
Feb 6, 2024

Conversation

barmac
Copy link
Member

@barmac barmac commented Feb 5, 2024

Closes #2053

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Feb 5, 2024
@barmac barmac changed the title chore: update changelog Update to diagram-js@14 Feb 5, 2024
@barmac
Copy link
Member Author

barmac commented Feb 5, 2024

I just noticed that this is an extended duplicate of #2079. Still let's use this PR as I've also updated the changelog.

@barmac barmac force-pushed the diagram-js-14 branch 2 times, most recently from 5d2b7e6 to f2b6d23 Compare February 5, 2024 15:01
@barmac barmac mentioned this pull request Feb 5, 2024
@barmac barmac marked this pull request as ready for review February 5, 2024 16:02
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 5, 2024
@barmac barmac requested review from a team, philippfromme and marstamm and removed request for a team February 5, 2024 16:02
CHANGELOG.md Outdated
@@ -6,6 +6,14 @@ All notable changes to [bpmn-js](https://github.com/bpmn-io/bpmn-js) are documen

___Note:__ Yet to be released changes appear here._

## 17.0.0

* `DEPS`: update to `[email protected]`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add additional improvements here:

Suggested change
* `DEPS`: update to `diagram-js@14.0.0`
* `FEAT`: add to selection through SHIFT ([bpmn-io/diagram-js#796](https://github.com/bpmn-io/diagram-js/pull/851), [#2053](https://github.com/bpmn-io/bpmn-js/issues/2053))
* `CHORE`: remove broken touch interaction ([bpmn-io/diagram-js#796](https://github.com/bpmn-io/diagram-js/issues/796))
* `DEPS`: update to `[email protected]`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will apply your suggestion on the release PR.

BREAKING CHANGES:

* Migrated to `diagram-js@14` which removes touch interaction module, and dependency on unsupported `hammerjs` package. If you rely on touch interaction, you need to support touch interaction on your own.

deps: update to `diagram-js@14`

feat: allow to add to selection via lasso tool

Closes #2053
@barmac barmac merged commit e7ced4e into develop Feb 6, 2024
9 checks passed
@barmac barmac deleted the diagram-js-14 branch February 6, 2024 10:10
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to add to selection using the lasso tool
2 participants