feat: remove touch interaction module

BREAKING CHANGES: * Migrated to `diagram-js@14` which removes touch interaction module, and dependency on unsupported `hammerjs` package. If you rely on touch interaction, you need to support touch interaction on your own. deps: update to `diagram-js@14` feat: allow to add to selection via lasso tool Closes #2053
bpmn-io · Feb 5, 2024 · f2b6d23 · f2b6d23
1 parent b176982
commit f2b6d23
Show file tree

Hide file tree

Showing 11 changed files with 22 additions and 76 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,14 @@ All notable changes to [bpmn-js](https://github.com/bpmn-io/bpmn-js) are documen
 
 ___Note:__ Yet to be released changes appear here._
 
+## 17.0.0
+
+* `DEPS`: update to `[email protected]`
+
+### Breaking Changes
+
+* Migrated to `diagram-js@14` which removes touch interaction module, and dependency on unsupported `hammerjs` package. If you rely on touch interaction, you need to support touch interaction on your own.
+
 ## 16.5.0
 
 * `FEAT`: handle adding vertical lanes ([#2086](https://github.com/bpmn-io/bpmn-js/issues/2086))

diff --git a/lib/Modeler.js b/lib/Modeler.js
@@ -7,7 +7,6 @@ import NavigatedViewer from './NavigatedViewer';
 
 import KeyboardMoveModule from 'diagram-js/lib/navigation/keyboard-move';
 import MoveCanvasModule from 'diagram-js/lib/navigation/movecanvas';
-import TouchModule from 'diagram-js/lib/navigation/touch';
 import ZoomScrollModule from 'diagram-js/lib/navigation/zoomscroll';
 
 import AlignElementsModule from './features/align-elements';
@@ -156,7 +155,6 @@ Modeler.prototype._interactionModules = [
   // non-modeling components
   KeyboardMoveModule,
   MoveCanvasModule,
-  TouchModule,
   ZoomScrollModule
 ];
 

diff --git a/lib/features/modeling/behavior/DataInputAssociationBehavior.js b/lib/features/modeling/behavior/DataInputAssociationBehavior.js
@@ -145,7 +145,7 @@ inherits(DataInputAssociationBehavior, CommandInterceptor);
 
 /**
  * Only call the given function when the event
- * touches a bpmn:DataInputAssociation.
+ * changes a bpmn:DataInputAssociation.
  *
  * @param {Function} fn
  * @return {Function}

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -111,7 +111,7 @@
   },
   "dependencies": {
     "bpmn-moddle": "^8.1.0",
-    "diagram-js": "^13.4.0",
+    "diagram-js": "^14.0.0",
     "diagram-js-direct-editing": "^2.1.1",
     "ids": "^1.0.5",
     "inherits-browser": "^0.1.0",

diff --git a/test/integration/CustomElementsSpec.js b/test/integration/CustomElementsSpec.js
@@ -12,9 +12,8 @@ import {
 
 import customElementsModules from './custom-elements';
 
-var noTouchInteractionModule = { touchInteractionEvents: [ 'value', null ] },
-    modelerModules = Modeler.prototype._modules,
-    customModules = [ customElementsModules, noTouchInteractionModule ];
+var modelerModules = Modeler.prototype._modules,
+    customModules = [ customElementsModules ];
 
 var testModules = [].concat(modelerModules, customModules);
 

diff --git a/test/spec/features/label-editing/TouchIntegrationSpec.js b/test/spec/features/label-editing/TouchIntegrationSpec.js
diff --git a/test/spec/features/modeling/LabelBoundsSpec.js b/test/spec/features/modeling/LabelBoundsSpec.js
@@ -321,7 +321,7 @@ describe('label bounds', function() {
     });
 
 
-    it('should not update DI of untouched labels', function() {
+    it('should not update DI of unchanged labels', function() {
 
       var xml = require('./LabelBoundsSpec.simple.bpmn');
 

diff --git a/test/spec/features/modeling/UpdatePropertiesSpec.js b/test/spec/features/modeling/UpdatePropertiesSpec.js
@@ -96,7 +96,7 @@ describe('features/modeling - update properties', function() {
     }));
 
 
-    it('should keep unchanged default flow untouched', inject(
+    it('should keep unchanged default flow intact', inject(
       function(elementRegistry, modeling) {
 
         // given

diff --git a/test/spec/features/modeling/behavior/DropOnFlowBehaviorSpec.js b/test/spec/features/modeling/behavior/DropOnFlowBehaviorSpec.js
@@ -11,8 +11,6 @@ import coreModule from 'lib/core';
 import moveModule from 'diagram-js/lib/features/move';
 import modelingModule from 'lib/features/modeling';
 
-var noTouchInteractionModule = { touchInteractionEvents: [ 'value', null ] };
-
 import {
   createCanvasEvent as canvasEvent
 } from '../../../../util/MockEvents';
@@ -26,7 +24,6 @@ describe('modeling/behavior - drop on connection', function() {
 
   beforeEach(bootstrapModeler(diagramXML, {
     modules: [
-      noTouchInteractionModule,
       moveModule,
       modelingModule,
       coreModule

diff --git a/test/spec/features/modeling/layout/LayoutConnectionSpec.js b/test/spec/features/modeling/layout/LayoutConnectionSpec.js
@@ -37,7 +37,7 @@ describe('features/modeling - layout connection', function() {
   }));
 
 
-  describe('should not touch already layouted', function() {
+  describe('should not change already layouted', function() {
 
     it('execute', inject(function(elementRegistry, modeling, bpmnFactory) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -321,7 +321,7 @@ describe('label bounds', function() { @@
         });
-        it('should not update DI of untouched labels', function() {
+        it('should not update DI of unchanged labels', function() {
           var xml = require('./LabelBoundsSpec.simple.bpmn');
@@ Expand Down @@