Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to add to selection using the lasso tool #2053

Closed
2 tasks
nikku opened this issue Dec 11, 2023 · 0 comments · Fixed by #2097
Closed
2 tasks

Allow to add to selection using the lasso tool #2053

nikku opened this issue Dec 11, 2023 · 0 comments · Fixed by #2097
Assignees
@philippfromme
Labels
enhancement New feature or request spring cleaning Could be cleaned up one day ux

Comments

@nikku
Copy link
Member

nikku commented Dec 11, 2023

Is your feature request related to a problem? Please describe.

As a user I want to often times add to the selection inside an existing diagram. Unfortunately using the lasso tool I currently cannot add more elements to the existing selection:

capture zwlhJV_optimized

Describe the solution you'd like

  • The lasso tool is SHIFT aware, adding to the existing selection
  • (Stretch) Keep the existing selection during the lasso tool, so that users know what is happening

Describe alternatives you've considered

None.

Additional context

Related to #2051.

This is a common interaction in drawing tools.
@nikku nikku added the enhancement New feature or request label Dec 11, 2023
@nikku nikku mentioned this issue Dec 11, 2023
Open
@nikku nikku added ux spring cleaning Could be cleaned up one day labels Dec 11, 2023
@nikku nikku added the backlog Queued in backlog label Dec 12, 2023 — with bpmn-io-tasks
@philippfromme philippfromme self-assigned this Jan 22, 2024
@philippfromme philippfromme added in progress Currently worked on and removed backlog Queued in backlog labels Jan 22, 2024
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jan 22, 2024
@philippfromme
feat(lasso-tool): add to selection through SHIFT
8f4d191 
Related to bpmn-io/bpmn-js#2053
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jan 22, 2024
@philippfromme
feat(lasso-tool): add to selection through SHIFT
de2b47f 
Related to bpmn-io/bpmn-js#2053
@philippfromme philippfromme mentioned this issue Jan 22, 2024
Merged
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jan 30, 2024
@philippfromme
feat(lasso-tool): add to selection through SHIFT
f6e83e6 
Related to bpmn-io/bpmn-js#2053
nikku pushed a commit to bpmn-io/diagram-js that referenced this issue Jan 30, 2024
@philippfromme @nikku
feat(lasso-tool): add to selection through SHIFT
b6a1912 
Related to bpmn-io/bpmn-js#2053
@philippfromme philippfromme added the needs review Review pending label Jan 30, 2024 — with bpmn-io-tasks
@philippfromme philippfromme removed the in progress Currently worked on label Jan 30, 2024
barmac pushed a commit to bpmn-io/diagram-js that referenced this issue Feb 1, 2024
@philippfromme @barmac
feat(lasso-tool): add to selection through SHIFT
c407b8e 
Related to bpmn-io/bpmn-js#2053
barmac pushed a commit to bpmn-io/diagram-js that referenced this issue Feb 5, 2024
@philippfromme
feat(lasso-tool): add to selection through SHIFT
292894d 
Related to bpmn-io/bpmn-js#2053
barmac added a commit that referenced this issue Feb 5, 2024
@barmac
feat: remove touch interaction module
f2b6d23 
BREAKING CHANGES:

* Migrated to `diagram-js@14` which removes touch interaction module, and dependency on unsupported `hammerjs` package. If you rely on touch interaction, you need to support touch interaction on your own.

deps: update to `diagram-js@14`

feat: allow to add to selection via lasso tool

Closes #2053
@philippfromme philippfromme added fixed upstream Requires integration of upstream change and removed needs review Review pending labels Feb 6, 2024
@barmac barmac mentioned this issue Feb 6, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Feb 6, 2024
barmac added a commit that referenced this issue Feb 6, 2024
@barmac
feat: remove touch interaction module
3e05e75 
BREAKING CHANGES:

* Migrated to `diagram-js@14` which removes touch interaction module, and dependency on unsupported `hammerjs` package. If you rely on touch interaction, you need to support touch interaction on your own.

deps: update to `diagram-js@14`

feat: allow to add to selection via lasso tool

Closes #2053
barmac added a commit that referenced this issue Feb 6, 2024
@barmac
feat: remove touch interaction module
e7ced4e 
BREAKING CHANGES:

* Migrated to `diagram-js@14` which removes touch interaction module, and dependency on unsupported `hammerjs` package. If you rely on touch interaction, you need to support touch interaction on your own.

deps: update to `diagram-js@14`

feat: allow to add to selection via lasso tool

Closes #2053
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 6, 2024
@github-actions github-actions bot mentioned this issue Feb 6, 2024
Merged
barmac added a commit that referenced this issue Feb 6, 2024
@barmac
feat: remove touch interaction module
9b2b6a6 
BREAKING CHANGE: Migrated to `diagram-js@14` which removes touch interaction module, and dependency on unsupported `hammerjs` package. If you rely on touch interaction, you need to support touch interaction on your own.

deps: update to `diagram-js@14`

feat: allow to add to selection via lasso tool

Closes #2053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
enhancement New feature or request spring cleaning Could be cleaned up one day ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to diagram-js@14 bpmn-io/bpmn-js
2 participants
@nikku @philippfromme