chore(extensions): add asciidoctor-tabs #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akantcheff
commented
Nov 8, 2023
•
akantcheff
commented
- Add Asciidoctor extension https://github.com/asciidoctor/asciidoctor-tabs and few example
- Improve the declaration CSS way. We can now use the classic CSS files with @import syntax
|
♻️ PR Preview 49294b1 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
akantcheff
force-pushed
the
chore/add-asciidoctor-tabs
branch
3 times, most recently
from
4df29e7 to
3be36c8
Compare
benjaminParisel
force-pushed
the
chore/add-asciidoctor-tabs
branch
from
3be36c8 to
12ea20b
Compare
tbouffard
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
❤️ Very cool features and very clear examples. Great job!!!!
ℹ️ There are some code smells spotted by SonarCloud. I don't know if the new code in the build.js file comes from the Antora Default UI (in this case, no need to change anything here, eventually, we could later do a PR in the original repo)
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.