Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(extensions): add asciidoctor-tabs #636

Merged
merged 3 commits into from
Nov 16, 2023
Merged

feat(extensions): add asciidoctor-tabs #636

merged 3 commits into from
Nov 16, 2023

Conversation

akantcheff
Copy link
Contributor

@akantcheff akantcheff commented Nov 7, 2023 •
edited
Loading

@akantcheff akantcheff force-pushed the chore/add-asciidoctor-tabs branch 3 times, most recently from 16ce96c to 3456514 Compare November 8, 2023 10:21
tbouffard
tbouffard requested changes Nov 8, 2023
View reviewed changes
antora-playbook.yml Outdated Show resolved Hide resolved
@akantcheff akantcheff force-pushed the chore/add-asciidoctor-tabs branch from 3456514 to 837a83c Compare November 8, 2023 15:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023 •
edited
Loading

♻️ PR Preview 759bb0a has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023 •
edited
Loading

♻️ PR Preview 759bb0a has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@tbouffard tbouffard marked this pull request as draft November 8, 2023 16:45
@akantcheff akantcheff marked this pull request as ready for review November 10, 2023 13:49
@benjaminParisel benjaminParisel force-pushed the chore/add-asciidoctor-tabs branch from 837a83c to d9f240e Compare November 10, 2023 14:27
tbouffard
tbouffard reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check this with a PR in bonita-doc to ensure everything run fine?
To proceed, you need to modify the workflow that builds the preview and make it use the branch of this PR. Please let me know if you need assistance to do this.

package.json Outdated Show resolved Hide resolved
@akantcheff
Copy link
Contributor Author

Can you please check this with a PR in bonita-doc to ensure everything run fine? To proceed, you need to modify the workflow that builds the preview and make it use the branch of this PR. Please let me know if you need assistance to do this.

I'm using the feature in bonitasoft/bonita-doc#2496 (@benjaminParisel helped me with the workflow)

@akantcheff
Copy link
Contributor Author

Can you please check this with a PR in bonita-doc to ensure everything run fine? To proceed, you need to modify the workflow that builds the preview and make it use the branch of this PR. Please let me know if you need assistance to do this.

I'm using the feature in bonitasoft/bonita-doc#2496 (@benjaminParisel helped me with the workflow)

The feature is working well. Agree to merge it?

@vhemery vhemery requested a review from tbouffard November 16, 2023 10:19
@tbouffard tbouffard mentioned this pull request Nov 16, 2023
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tbouffard
tbouffard approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Validated with bonitasoft/bonita-doc#2496
🎉 Good job!

@tbouffard tbouffard changed the title chore(extensions): add asciidoctor-tabs feat(extensions): add asciidoctor-tabs Nov 16, 2023
@tbouffard tbouffard merged commit e094b9b into master Nov 16, 2023
6 checks passed
@tbouffard tbouffard deleted the chore/add-asciidoctor-tabs branch November 16, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akantcheff @tbouffard