Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(docker): rework docker installation page #2496

Merged
merged 33 commits into from
Nov 16, 2023
Merged

docs(docker): rework docker installation page #2496

merged 33 commits into from
Nov 16, 2023

Conversation

akantcheff
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023 •
edited
Loading

♻️ PR Preview b4749eb has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023 •
edited
Loading

📝 Check the pages that have been modified

In order to merge this pull request, you need to check your updates with the following url.

🔍 Updated pages

The following pages were updated, please ensure that the display is correct:

@akantcheff akantcheff force-pushed the doc/docker-installation branch 3 times, most recently from d57e776 to b9e8783 Compare November 7, 2023 16:57
@akantcheff akantcheff force-pushed the doc/docker-installation branch 2 times, most recently from 3945077 to e78b2e5 Compare November 10, 2023 14:50
@akantcheff akantcheff mentioned this pull request Nov 10, 2023
Merged
@akantcheff akantcheff force-pushed the doc/docker-installation branch from 00f0d7c to fbc0081 Compare November 10, 2023 16:43
@akantcheff akantcheff marked this pull request as ready for review November 10, 2023 16:50
@akantcheff
Copy link
Contributor Author

@vhemery can you commit all changes in one batch please to easily see changes and to prevent rebuilding the PR for each commits

@vhemery
Copy link
Contributor

vhemery commented Nov 16, 2023 •
edited
Loading

@vhemery can you commit all changes in one batch please to easily see changes and to prevent rebuilding the PR for each commits

I wish I could with Github edition... (on second though, I probably could have done it with a PR to the PR branch)
All done now.

@vhemery vhemery requested a review from rbioteau November 16, 2023 10:12
@tbouffard tbouffard marked this pull request as draft November 16, 2023 10:25
@tbouffard
Copy link
Member

Put in draft as this PR requires

akantcheff and others added 9 commits November 16, 2023 11:39
@akantcheff @vhemery
docs(docker): rework docker installation page
6acfbac
@akantcheff @vhemery
REVERT-ME: link to chore/add-asciidoctor-tabs
1bb1f68
@akantcheff @vhemery
fix(tabs): remove comments that broke tabs layout
eb99643
@vhemery
Update docker-compose.yml
3861714 
Docker compose deployment: Clarify version and give example for built Applications
@vhemery
Update docker-compose.yml
3e7c6e6 
Docker compose deployment: Clarify version and give example for built Applications
@vhemery
Update docker-compose.yml
f5149fb
@vhemery
Update docker-compose.yml
b9e6610
@vhemery
Update docker-compose.yml
2977c0b 
Docker compose deployment: Clarify version and give example for built Applications
@vhemery
Update docker-compose.yml
2140a6f 
Docker compose deployment: Clarify version and give example for built Applications
@vhemery vhemery force-pushed the doc/docker-installation branch from 2317f4b to 4201213 Compare November 16, 2023 10:39
@vhemery vhemery marked this pull request as ready for review November 16, 2023 11:08
@vhemery vhemery requested a review from rbioteau November 16, 2023 11:19
educhastenier
educhastenier reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@educhastenier educhastenier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review...

modules/runtime/examples/docker/cluster/docker-compose.yml Outdated Show resolved Hide resolved
modules/runtime/examples/docker/community/mysql/docker-compose.yml Outdated Show resolved Hide resolved
modules/runtime/examples/docker/community/postgres/docker-compose.yml Outdated Show resolved Hide resolved
modules/runtime/examples/docker/community/sqlserver/docker-compose.yml Outdated Show resolved Hide resolved
modules/runtime/examples/docker/subscription/mysql/docker-compose.yml Outdated Show resolved Hide resolved
modules/runtime/examples/docker/subscription/postgres/docker-compose.yml Outdated Show resolved Hide resolved
modules/runtime/examples/docker/subscription/sqlserver/docker-compose.yml Outdated Show resolved Hide resolved
vhemery and others added 7 commits November 16, 2023 15:43
@vhemery @educhastenier
Update modules/runtime/examples/docker/cluster/docker-compose.yml
6927162 
Co-authored-by: Emmanuel Duchastenier <[email protected]>
@vhemery @educhastenier
Update modules/runtime/examples/docker/community/mysql/docker-compose…
e2c25f7 
….yml

Co-authored-by: Emmanuel Duchastenier <[email protected]>
@vhemery @educhastenier
Update modules/runtime/examples/docker/subscription/postgres/docker-c…
04275fb 
…ompose.yml

Co-authored-by: Emmanuel Duchastenier <[email protected]>
@vhemery @educhastenier
Update modules/runtime/examples/docker/community/sqlserver/docker-com…
fb0749d 
…pose.yml

Co-authored-by: Emmanuel Duchastenier <[email protected]>
@vhemery @educhastenier
Update modules/runtime/examples/docker/subscription/mysql/docker-comp…
4acbe23 
…ose.yml

Co-authored-by: Emmanuel Duchastenier <[email protected]>
@vhemery @educhastenier
Update modules/runtime/examples/docker/subscription/sqlserver/docker-…
f562ac3 
…compose.yml

Co-authored-by: Emmanuel Duchastenier <[email protected]>
@vhemery @educhastenier
Update modules/runtime/examples/docker/community/postgres/docker-comp…
b4749eb 
…ose.yml

Co-authored-by: Emmanuel Duchastenier <[email protected]>
@vhemery vhemery merged commit e30fedc into 2023.2 Nov 16, 2023
3 checks passed
@vhemery vhemery deleted the doc/docker-installation branch November 16, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@educhastenier educhastenier educhastenier left review comments

@vhemery vhemery vhemery approved these changes

@rbioteau rbioteau rbioteau approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akantcheff @vhemery @tbouffard @rbioteau @educhastenier