Lookup by appId #309
Merged
Lookup by appId #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorjesinpo
force-pushed
the
dev/VSC-TwoKeyHashMap
branch
from
d8cdd77 to
33b870e
Compare
Signed-off-by: dorjesinpo <[email protected]>
dorjesinpo
force-pushed
the
dev/VSC-TwoKeyHashMap
branch
from
33b870e to
11a7645
Compare
678098
previously approved these changes
May 31, 2024
| @@ -58,8 +61,9 @@ class VirtualStorageCatalog { | |||
| typedef bsl::shared_ptr<VirtualStorage> VirtualStorageSp; | |||
|
|
|||
| /// appKey -> virtualStorage | |||
There was a problem hiding this comment.
Need to update the comment here.
/// Any(appId, appKey) -> virtualStorage
| if (appKey) { | ||
| *appKey = it->first; | ||
| } | ||
| VirtualStoragesConstIter cit = d_virtualStorages.findByKey1(appId); |
| } | ||
|
|
||
| // Add guid to all virtual storages. | ||
|
|
||
| for (VirtualStoragesIter it = d_virtualStorages.begin(); | ||
| it != d_virtualStorages.end(); | ||
| ++it) { | ||
| it->second->put(msgGUID, msgSize, rdaInfo, subScriptionId); | ||
| it->value()->put(msgGUID, msgSize, rdaInfo, subScriptionId); |
There was a problem hiding this comment.
We don't check for return codes here, what if one or few put fails?
Currently, VirtualStorage::put might fail if GUID is not unique
On comparison, we might return e_GUID_NOT_UNIQUE on line 67
There was a problem hiding this comment.
Looks like this codepath (appKey.isNull()) is for unique GUIDs only. The callers do not even check the return code.
We can add error code without affecting anything, I guess
Signed-off-by: dorjesinpo <[email protected]>
678098
approved these changes
May 31, 2024
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
* Lookup by appId Signed-off-by: dorjesinpo <[email protected]> * VirtualStorageCatalog::put returns error Signed-off-by: dorjesinpo <[email protected]> --------- Signed-off-by: dorjesinpo <[email protected]>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
* Lookup by appId Signed-off-by: dorjesinpo <[email protected]> * VirtualStorageCatalog::put returns error Signed-off-by: dorjesinpo <[email protected]> --------- Signed-off-by: dorjesinpo <[email protected]>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
* Lookup by appId Signed-off-by: dorjesinpo <[email protected]> * VirtualStorageCatalog::put returns error Signed-off-by: dorjesinpo <[email protected]> --------- Signed-off-by: dorjesinpo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid iteration in
VirtualStorageCatalog::hasVirtualStorage(const bsl::string& appIdby switching toTwoKeyHashMapPreparatory step for Reliable Broadcast