VirtualStorageCatalog::put returns error

Signed-off-by: dorjesinpo <[email protected]>
bloomberg · May 31, 2024 · ff2a834 · ff2a834
1 parent 11a7645
commit ff2a834
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/groups/mqb/mqbs/mqbs_virtualstoragecatalog.cpp b/src/groups/mqb/mqbs/mqbs_virtualstoragecatalog.cpp
@@ -71,14 +71,18 @@ VirtualStorageCatalog::put(const bmqt::MessageGUID& msgGUID,
     }
 
     // Add guid to all virtual storages.
-
+    mqbi::StorageResult::Enum lastRc = mqbi::StorageResult::e_SUCCESS;
     for (VirtualStoragesIter it = d_virtualStorages.begin();
          it != d_virtualStorages.end();
          ++it) {
-        it->value()->put(msgGUID, msgSize, rdaInfo, subScriptionId);
+        mqbi::StorageResult::Enum rc =
+            it->value()->put(msgGUID, msgSize, rdaInfo, subScriptionId);
+        if (rc != mqbi::StorageResult::e_SUCCESS) {
+            lastRc = rc;
+        }
     }
 
-    return mqbi::StorageResult::e_SUCCESS;  // RETURN
+    return lastRc;  // RETURN
 }
 
 bslma::ManagedPtr<mqbi::StorageIterator>

diff --git a/src/groups/mqb/mqbs/mqbs_virtualstoragecatalog.h b/src/groups/mqb/mqbs/mqbs_virtualstoragecatalog.h
@@ -60,7 +60,7 @@ class VirtualStorageCatalog {
     // PRIVATE TYPES
     typedef bsl::shared_ptr<VirtualStorage> VirtualStorageSp;
 
-    /// appKey -> virtualStorage
+    /// Any(appId, appKey) -> virtualStorage
     typedef mwcc::
         TwoKeyHashMap<bsl::string, mqbu::StorageKey, VirtualStorageSp>
             VirtualStorages;