fix: reduce controller log warnings #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbillman
requested review from
alecthomas,
dhanji and
worstell
as code owners
8 tasks
alecthomas
reviewed
Feb 7, 2024
| @@ -857,7 +857,7 @@ func (s *Service) reconcileDeployments(ctx context.Context) (time.Duration, erro | |||
| deploymentLogger.Debugf("Need %d more runners for %s", require, reconcile.Deployment) | |||
| wg.Go(func(ctx context.Context) error { | |||
| if err := s.deploy(ctx, deployment); err != nil { | |||
| deploymentLogger.Warnf("Failed to increase deployment replicas: %s", err) | |||
There was a problem hiding this comment.
This should really be logged at error, but only if we've already tried to increase replicas and it's failed once.
The other log messages are fine to be at Debug I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of removing these log messages, I lowered them to
Debugin case they are useful in the future. I can remove if that's preferred as well.