Skip to content

Commit

Permalink
fix: reduce controller log warnings (#890)
Browse files Browse the repository at this point in the history
Instead of removing these log messages, I lowered them to `Debug` in
case they are useful in the future. I can remove if that's preferred as
well.
  • Loading branch information
wesbillman authored Feb 7, 2024
1 parent a2a55a8 commit 51565fb
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions backend/controller/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,7 @@ func (s *Service) reapStaleRunners(ctx context.Context) (time.Duration, error) {
if err != nil {
return 0, fmt.Errorf("%s: %w", "Failed to delete stale runners", err)
} else if count > 0 {
logger.Warnf("Reaped %d stale runners", count)
logger.Debugf("Reaped %d stale runners", count)
}
return s.config.RunnerTimeout, nil
}
Expand Down Expand Up @@ -857,7 +857,7 @@ func (s *Service) reconcileDeployments(ctx context.Context) (time.Duration, erro
deploymentLogger.Debugf("Need %d more runners for %s", require, reconcile.Deployment)
wg.Go(func(ctx context.Context) error {
if err := s.deploy(ctx, deployment); err != nil {
deploymentLogger.Warnf("Failed to increase deployment replicas: %s", err)
deploymentLogger.Debugf("Failed to increase deployment replicas: %s", err)
} else {
deploymentLogger.Debugf("Reconciled %s", reconcile.Deployment)
}
Expand Down Expand Up @@ -973,7 +973,7 @@ func (s *Service) reapStaleControllers(ctx context.Context) (time.Duration, erro
if err != nil {
return 0, fmt.Errorf("%s: %w", "failed to delete stale controllers", err)
} else if count > 0 {
logger.Warnf("Reaped %d stale controllers", count)
logger.Debugf("Reaped %d stale controllers", count)
}
return time.Second * 10, nil
}
Expand Down

0 comments on commit 51565fb

Please sign in to comment.