fix: add go.mod file to jvm scaffolding dirs #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without these the Go toolchain tries to scan the directories and fails due to the | characters, which are not supported by Go's build system.
alecthomas
requested review from
a team and
deniseli
and removed request for
a team
Open
safeer
pushed a commit
that referenced
this pull request
Aug 19, 2024
Without these the Go toolchain tries to scan the directories and fails
due to the | characters, which are not supported by Go's build system.
Fixes the following failure:
```
info: go: finding module for package github.com/TBD54566975/ftl/go-runtime/ftl
go: downloading github.com/TBD54566975/ftl v0.345.0
go: ftl/builtin imports
github.com/TBD54566975/ftl/go-runtime/ftl: create zip: jvm-runtime/java/scaffolding/{{ .Name | camel | lower }}/ftl.toml: malformed file path "jvm-runtime/java/scaffolding/{{ .Name | camel | lower }}/ftl.toml": invalid char '|'
jvm-runtime/java/scaffolding/{{ .Name | camel | lower }}/pom.xml.tmpl: malformed file path "jvm-runtime/java/scaffolding/{{ .Name | camel | lower }}/pom.xml.tmpl": invalid char '|'
jvm-runtime/java/scaffolding/{{ .Name | camel | lower }}/src/main/java/{{ .PackageDir }}/EchoVerb.java: malformed file path "jvm-runtime/java/scaffolding/{{ .Name | camel | lower }}/src/main/java/{{ .PackageDir }}/EchoVerb.java": invalid char '|'
jvm-runtime/kotlin/scaffolding/{{ .Name | camel | lower }}/ftl.toml: malformed file path "jvm-runtime/kotlin/scaffolding/{{ .Name | camel | lower }}/ftl.toml": invalid char '|'
jvm-runtime/kotlin/scaffolding/{{ .Name | camel | lower }}/pom.xml.tmpl: malformed file path "jvm-runtime/kotlin/scaffolding/{{ .Name | camel | lower }}/pom.xml.tmpl": invalid char '|'
jvm-runtime/kotlin/scaffolding/{{ .Name | camel | lower }}/src/main/kotlin/{{ .PackageDir }}/EchoVerb.kt: malformed file path "jvm-runtime/kotlin/scaffolding/{{ .Name | camel | lower }}/src/main/kotlin/{{ .PackageDir }}/EchoVerb.kt": invalid char '|'
```
There is an underlying bug that is triggering this, whereby replace
directives aren't correctly propagated to the shared Go FTL module
stubs. Filed #2415 for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these the Go toolchain tries to scan the directories and fails due to the | characters, which are not supported by Go's build system.
Fixes the following failure:
There is an underlying bug that is triggering this, whereby replace directives aren't correctly propagated to the shared Go FTL module stubs. Filed #2415 for this.