fix(integration): create a new test dir per language #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
added
the
run-all
alecthomas
requested review from
a team and
stuartwdouglas
and removed request for
a team
Open
alecthomas
force-pushed
the
aat/new-test-dir-per-language
branch
3 times, most recently
from
4203045 to
8c04531
Compare
jvm-runtime/java/scaffolding/go.mod
Outdated
| @@ -0,0 +1,3 @@ | |||
| module ignore | |||
|
|
|||
| go 1.22.6 | |||
There was a problem hiding this comment.
Just out of curiosity why is this necessary? I understand why you need it for the go scaffolding but I assumed this would not be needed for Java as there are no go files in the directory?
There was a problem hiding this comment.
I ended up fixing this separately in #2414, I explained it in a bit more detail there.
stuartwdouglas
approved these changes
Aug 17, 2024
stuartwdouglas
force-pushed
the
aat/new-test-dir-per-language
branch
from
8c04531 to
509d206
Compare
alecthomas
force-pushed
the
aat/new-test-dir-per-language
branch
from
509d206 to
1356361
Compare
alecthomas
force-pushed
the
aat/new-test-dir-per-language
branch
from
1356361 to
275c4fa
Compare
safeer
pushed a commit
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2412