fix: improve lease log level and include key #2163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
matt2e
force-pushed
the
matt2e/lease-state
branch
from
7ca4201 to
c2937a8
Compare
|
Accidentally included this change in this PR #2165 🤦♂️🤦♂️🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2159
fixes #2160
lease.errwas not set properly because the struct was not referenced via a pointer so the state was not shared.state: *leaseStateto get around this (rather than making the lease handle a pointer) because it also made clear what the mutex is protecting. Not a strong opinion though, happy to do the other approach if people feel that it's cleaner.