Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include lease name in log for when lease expires for a module #2159

Closed
matt2e opened this issue Jul 24, 2024 · 1 comment
Closed

Include lease name in log for when lease expires for a module #2159

matt2e opened this issue Jul 24, 2024 · 1 comment
Assignees
@matt2e

Comments

@matt2e
Copy link
Collaborator

matt2e commented Jul 24, 2024 •
edited
Loading

Current log message from the runner: Lease heartbeat terminated: canceled: context canceled
It would be helpful to debug this by knowing the actual name of the lease
Same for Renewing lease log messages from the controller
@github-actions github-actions bot added the triage Issue needs triaging label Jul 24, 2024
@ftl-robot ftl-robot mentioned this issue Jul 24, 2024
Open
@matt2e matt2e self-assigned this Jul 24, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Jul 24, 2024
@matt2e matt2e mentioned this issue Jul 25, 2024
Closed
@matt2e
Copy link
Collaborator Author

matt2e commented Jul 28, 2024

Fixed in #2163

@matt2e matt2e closed this as completed Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matt2e matt2e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve lease log level and include key block/ftl
1 participant
@matt2e