Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no need to specify —opvault to access secrets #2071

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix: no need to specify —opvault to access secrets #2071

merged 2 commits into from
Jul 15, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Jul 15, 2024

Changes:

  • Asynchronous providers are given a list of known entries when syncing
  • 1Password provider uses these entries to know which vaults to sync
  • Removed logic for whether an asynchronous provider was active. This was there to make sure we didnt attempt syncing with 1Password for projects that weren't using 1Password. This is now solved by 1PasswordProvider only syncing known vaults.

@matt2e matt2e requested a review from alecthomas as a code owner July 15, 2024 01:22
@matt2e matt2e requested review from a team and worstell and removed request for a team July 15, 2024 01:22
@ftl-robot ftl-robot mentioned this pull request Jul 15, 2024
Open
@matt2e matt2e mentioned this pull request Jul 15, 2024
Closed
@gak gak self-requested a review July 15, 2024 01:41
gak
gak approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@gak gak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matt2e matt2e merged commit d012354 into main Jul 15, 2024
54 checks passed
@matt2e matt2e deleted the matt2e/no-opvault branch July 15, 2024 01:56
@matt2e matt2e mentioned this pull request Jul 15, 2024
Closed
@worstell worstell added the approved Marks an already closed PR as approved label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gak gak gak approved these changes

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

@worstell worstell Awaiting requested review from worstell

Assignees
No one assigned
Labels
approved Marks an already closed PR as approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matt2e @gak @worstell