fix: require an ftl-project.toml file #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
requested review from
a team and
worstell
and removed request for
a team
Open
alecthomas
force-pushed
the
aat/require-project-config
branch
from
832e359 to
4fc42a6
Compare
worstell
approved these changes
Jun 13, 2024
alecthomas
force-pushed
the
aat/require-project-config
branch
3 times, most recently
from
06f4b76 to
90040a2
Compare
This is a global requirement across all commands, not scoped specifically to `ftl serve` or `ftl dev`, because eg. `ftl secret`/`ftl config`, etc. etc. all require this config file, and it's just cleaner/safer to do it in one location. Fixes #1669
alecthomas
force-pushed
the
aat/require-project-config
branch
from
90040a2 to
820d896
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a global requirement across all commands, not scoped specifically to
ftl serveorftl dev, because eg.ftl secret/ftl config, etc. etc. all require this config file, and it's just cleaner/safer to do it in one location.Also fixed soooooo many bugs!
Fixes #1669