Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate secrets/config against the schema before setting the value #1800

Closed
alecthomas opened this issue Jun 16, 2024 · 0 comments · Fixed by #1858
Closed

Validate secrets/config against the schema before setting the value #1800

alecthomas opened this issue Jun 16, 2024 · 0 comments · Fixed by #1858
Assignees

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented Jun 16, 2024

Now that we (mostly) have secrets/config going through the controller, we should add validation when setting them. For the controller version the schema can be loaded from the DB, but for the purely local case we'd need to load the schema from the build directory. I can't recall if we have any generic "validate this data against this schema" mechanism, so we might need to implement that first if not.

This might be contingent on #1775

@github-actions github-actions bot added the triage Issue needs triaging label Jun 16, 2024
@ftl-robot ftl-robot mentioned this issue Jun 16, 2024
@safeer safeer added next Work that will be be picked up next and removed triage Issue needs triaging labels Jun 17, 2024
@safeer safeer self-assigned this Jun 18, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Jun 18, 2024
@safeer safeer closed this as completed in f4cb64a Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants