fix: do not treat subpackage paths as part of the current package #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt2e
requested review from
a team and
wesbillman
and removed request for
a team
Open
matt2e
commented
May 17, 2024
| @@ -398,46 +398,46 @@ func TestErrorReporting(t *testing.T) { | |||
| filename := filepath.Join(pwd, `testdata/failing/failing.go`) | |||
| actual := slices.Map(r.MustGet().Errors, func(e *schema.Error) string { return strings.TrimPrefix(e.Error(), filename+":") }) | |||
| expected := []string{ | |||
| `10:13-34: first argument to config and secret declarations must be the name as a string literal`, | |||
There was a problem hiding this comment.
the new import has moved everything down a line...
matt2e
force-pushed
the
matt2e/improve-path-in-pkg
branch
from
7cc2796 to
81188b6
Compare
matt2e
commented
May 17, 2024
go-runtime/compile/schema_test.go
Outdated
| `153:2-2: unsupported type ftl/failing/child.ChildString from subpackage`, | ||
| `153:2-8: unsupported type "ftl/failing/child.ChildString" for field "String"`, | ||
| `157:1-1: unsupported type ftl/failing/child.ChildStruct from subpackage`, | ||
| `157:1-33: unsupported type "struct{Name string}" for type alias`, |
There was a problem hiding this comment.
errors for line 152 onwards are what are actually being surfaced with the new test change
matt2e
force-pushed
the
matt2e/improve-path-in-pkg
branch
from
81188b6 to
8602e70
Compare
|
This wasn't as neat as I'd hoped. Originally I was hoping it'd just be a change to |
alecthomas
approved these changes
May 17, 2024
go-runtime/compile/schema.go
Outdated
| func (p *parseContext) isPathInPkg(path string) bool { | ||
| if path == p.pkg.PkgPath { | ||
| return true | ||
| if strings.Contains(path, "namedext") { |
# Conflicts: # go-runtime/compile/schema_test.go # go-runtime/compile/testdata/failing/failing.go
# Conflicts: # go-runtime/compile/schema_test.go
matt2e
force-pushed
the
matt2e/improve-path-in-pkg
branch
from
81974a3 to
f01b5fa
Compare
matt2e
added a commit
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1529