Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow subpackage types #1558

Merged
merged 2 commits into from
May 23, 2024
Merged

fix: allow subpackage types #1558

merged 2 commits into from
May 23, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented May 22, 2024

Reverts two PRs:

This is a blunt fix to unblock based on our priorities. We should revisit #1535 again later

matt2e added 2 commits May 23, 2024 09:45
@matt2e
Revert "fix: support inlined or aliased structs as type enum variants (…
62d307d 
…#1535)"

This reverts commit 21df777.

# Conflicts:
#	go-runtime/compile/schema_test.go
#	go-runtime/compile/testdata/failing/failing.go
@matt2e
Revert "fix: do not treat subpackage paths as part of the current pac…
c04c7c3 
…kage (#1530)"

This reverts commit 3f74d1c.

# Conflicts:
#	go-runtime/compile/schema.go
#	go-runtime/compile/schema_test.go
#	go-runtime/compile/testdata/failing/failing.go
@matt2e matt2e requested a review from alecthomas as a code owner May 22, 2024 23:52
@matt2e matt2e requested review from a team and deniseli and removed request for a team May 22, 2024 23:52
@ftl-robot ftl-robot mentioned this pull request May 22, 2024
Open
@matt2e matt2e mentioned this pull request May 22, 2024
Closed
@matt2e matt2e merged commit ad82760 into main May 23, 2024
25 checks passed
@matt2e matt2e deleted the matt2e/allow-subpackage-types branch May 23, 2024 00:03
alecthomas
alecthomas approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you think this is the best approach vs. being surgical?

@matt2e matt2e mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deniseli deniseli deniseli approved these changes

@alecthomas alecthomas alecthomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matt2e @alecthomas @deniseli