Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parallelize deployments #1042

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix: parallelize deployments #1042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 39 additions & 9 deletions buildengine/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,7 @@ func (e *Engine) Dev(ctx context.Context, period time.Duration) error {
logger := log.FromContext(ctx)

// Build and deploy all modules first.
err := e.buildWithCallback(ctx, func(ctx context.Context, module Module) error {
return Deploy(ctx, module, 1, true, e.client)
})
err := e.buildAndDeploy(ctx, 1, true)
if err != nil {
logger.Errorf(err, "initial deploy failed")
}
Expand Down Expand Up @@ -223,13 +221,45 @@ func (e *Engine) Dev(ctx context.Context, period time.Duration) error {
}

func (e *Engine) buildAndDeploy(ctx context.Context, replicas int32, waitForDeployOnline bool, modules ...string) error {
err := e.buildWithCallback(ctx, func(ctx context.Context, module Module) error {
return Deploy(ctx, module, replicas, waitForDeployOnline, e.client)
}, modules...)
if err != nil {
return err
if len(modules) == 0 {
modules = maps.Keys(e.modules)
}
return nil

deployQueue := make(chan Module, len(modules))
wg, ctx := errgroup.WithContext(ctx)

wg.Go(func() error {
defer close(deployQueue)

return e.buildWithCallback(ctx, func(ctx context.Context, module Module) error {
select {
case deployQueue <- module:
return nil
case <-ctx.Done():
return ctx.Err()
}
}, modules...)
})

for i := 0; i < len(modules); i++ {
wg.Go(func() error {
for {
select {
case module, ok := <-deployQueue:
if !ok {
return nil
}
if err := Deploy(ctx, module, replicas, waitForDeployOnline, e.client); err != nil {
return err
}
case <-ctx.Done():
return ctx.Err()
}
}
})
}

return wg.Wait()
}

type buildCallback func(ctx context.Context, module Module) error
Expand Down