fix: parallelize deployments #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
wesbillman
commented
Mar 7, 2024
buildengine/engine.go
Outdated
Comment on lines
229
to
230
| wg, ctx := errgroup.WithContext(ctx) | ||
| wg.SetLimit(runtime.NumCPU()) |
There was a problem hiding this comment.
I tried to follow the pattern in the build command to limit the concurrency. Not 100% sure if this is the best solution of if there's something else I should try here.
There was a problem hiding this comment.
You probably don't need the same limit for deploys, it will be mostly network bound I think. You can probably remove the limit for now.
alecthomas
approved these changes
Mar 7, 2024
buildengine/engine.go
Outdated
Comment on lines
229
to
230
| wg, ctx := errgroup.WithContext(ctx) | ||
| wg.SetLimit(runtime.NumCPU()) |
There was a problem hiding this comment.
You probably don't need the same limit for deploys, it will be mostly network bound I think. You can probably remove the limit for now.
buildengine/engine.go
Outdated
|
|
||
| for i := 0; i < len(modules); i++ { | ||
| wg.Go(func() error { | ||
| for module := range deployQueue { |
There was a problem hiding this comment.
This should be a for loop with a select inside, that checks <-ctx.Done() as the other Go call does.
wesbillman
force-pushed
the
parallelize-deployments
branch
from
723b6ba to
2a577ad
Compare
wesbillman
force-pushed
the
parallelize-deployments
branch
from
2a577ad to
a2d1400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1031
Introduces non-blocking deploys so that they can while other modules are build.
BEFORE (20s cold, 11s warm):
AFTER (16s cold, 8s warm):
