Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTL http ingress error handling (response payloads) #2162

Closed
wesbillman opened this issue Jul 25, 2024 · 0 comments · Fixed by #2178
Closed

FTL http ingress error handling (response payloads) #2162

wesbillman opened this issue Jul 25, 2024 · 0 comments · Fixed by #2178
Assignees
@stuartwdouglas
Labels
good first issue Good for newcomers P1

Comments

@wesbillman
Copy link
Collaborator

wesbillman commented Jul 25, 2024 •
edited
Loading

A customer brought up the fact that they get a lot of the error dump returned on a HTTP ingress error. Should we just return 500 with an empty body rather than sending back error information?

For example, if schema validation fails on a ftl.call it will return 500 AND the schema validation error information.
@github-actions github-actions bot added the triage Issue needs triaging label Jul 25, 2024
@ftl-robot ftl-robot mentioned this issue Jul 25, 2024
Open
@alecthomas alecthomas added P0 Work on this now next Work that will be be picked up next labels Jul 25, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Jul 25, 2024
@alecthomas alecthomas added P1 good first issue Good for newcomers and removed P0 Work on this now labels Jul 25, 2024
@stuartwdouglas stuartwdouglas self-assigned this Jul 25, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Jul 25, 2024
stuartwdouglas added a commit that referenced this issue Jul 26, 2024
@stuartwdouglas
fix: don't include error in response
f1ed4d5 
Also make sure we log errors related to HTTP processing.

closes #2162
@stuartwdouglas stuartwdouglas mentioned this issue Jul 26, 2024
Merged
stuartwdouglas added a commit that referenced this issue Jul 26, 2024
@stuartwdouglas
fix: don't include error in response
2c4e970 
Also make sure we log errors related to HTTP processing.

closes #2162
stuartwdouglas added a commit that referenced this issue Jul 26, 2024
@stuartwdouglas
fix: don't include error in response
efcc46f 
Also make sure we log errors related to HTTP processing.

closes #2162
stuartwdouglas added a commit that referenced this issue Jul 26, 2024
@stuartwdouglas
fix: don't include error in response
d2b9fe9 
Also make sure we log errors related to HTTP processing.

closes #2162
@stuartwdouglas stuartwdouglas mentioned this issue Sep 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartwdouglas stuartwdouglas

Labels
good first issue Good for newcomers P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't include error in response block/ftl
3 participants
@alecthomas @wesbillman @stuartwdouglas