fix: don't include error in response #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested review from
a team and
worstell
and removed request for
a team
stuartwdouglas
commented
Jul 26, 2024
| @@ -18,6 +18,8 @@ import ( | |||
| "github.com/TBD54566975/ftl/internal/model" | |||
| ) | |||
|
|
|||
| const internalServerError = "Internal Server Error" | |||
There was a problem hiding this comment.
An open question is if we want to include this message or just an empty string.
There was a problem hiding this comment.
Suggested change
| const internalServerError = "Internal Server Error" | |
| const internalServerError = http.StatusText(http.StatusInternalServerError) |
(or inline that call elsewhere)
There was a problem hiding this comment.
I don't think that compiles, I would need to inline it
There was a problem hiding this comment.
Although it did make me realize I am sending the wrong message in some places
There was a problem hiding this comment.
Make it var .. to compile.
There was a problem hiding this comment.
I inlined it as some of the messages were for different response codes
Open
stuartwdouglas
force-pushed
the
stuartwdouglas/2162
branch
from
f1ed4d5 to
2c4e970
Compare
alecthomas
reviewed
Jul 26, 2024
stuartwdouglas
force-pushed
the
stuartwdouglas/2162
branch
from
2c4e970 to
efcc46f
Compare
Also make sure we log errors related to HTTP processing. closes #2162
stuartwdouglas
force-pushed
the
stuartwdouglas/2162
branch
from
efcc46f to
d2b9fe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make sure we log errors related to HTTP processing.
closes #2162