Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal error details should not be shown to the user #2482

Closed
stuartwdouglas opened this issue Aug 22, 2024 · 1 comment
Closed

Internal error details should not be shown to the user #2482

stuartwdouglas opened this issue Aug 22, 2024 · 1 comment
Assignees

Comments

@stuartwdouglas
Copy link
Collaborator

If we are returning an error on a HTTP request we should not be returning the details of our internal error, as this is a security risk (except in dev mode).

An alternative is to generate a unique error id that we include in the error message and the logs, so we can correlate a users error message with logs in DD.

@stuartwdouglas
Copy link
Collaborator Author

Looks like this should be fine now, as it was fixed in #2162

If an explicit error body is returned then it is still shown, but I think that is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants