Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease ftl serve startup and reconciliation time #1010

Closed
alecthomas opened this issue Mar 4, 2024 · 1 comment · Fixed by #1278 or #1465
Closed

Decrease ftl serve startup and reconciliation time #1010

alecthomas opened this issue Mar 4, 2024 · 1 comment · Fixed by #1278 or #1465
Assignees
@alecthomas
Labels
enhancement New feature or request

Comments

@alecthomas
Copy link
Collaborator

ftl serve uses the same timeouts as the production controller/runners, so under some circumstances it can easily take 5-10 seconds before the controller and runners come up. We should tune these timeouts so that it's basically instantaneous.

These timeouts are (almost?) all in controller.go.
@github-actions github-actions bot added the triage Issue needs triaging label Mar 4, 2024
@alecthomas alecthomas mentioned this issue Mar 4, 2024
Open
@alecthomas alecthomas added enhancement New feature or request next Work that will be be picked up next and removed triage Issue needs triaging labels Mar 4, 2024
@worstell worstell self-assigned this Apr 15, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Apr 15, 2024
worstell added a commit that referenced this issue Apr 16, 2024
@worstell
chore: decrease devel startup/reconciliation time
44b3b4f 
fixes #1010
@worstell worstell mentioned this issue Apr 16, 2024
Merged
worstell added a commit that referenced this issue Apr 16, 2024
@worstell
chore: decrease devel startup/reconciliation time
20d78b8 
fixes #1010
worstell added a commit that referenced this issue Apr 16, 2024
@worstell
chore: decrease devel startup/reconciliation time
1d84771 
fixes #1010
worstell added a commit that referenced this issue Apr 16, 2024
@worstell
chore: decrease devel startup/reconciliation time
327d47a 
fixes #1010
worstell added a commit that referenced this issue Apr 16, 2024
@worstell
chore: decrease devel startup/reconciliation time (#1278)
b0fd7d3 
fixes #1010
@worstell worstell reopened this Apr 18, 2024
@worstell worstell assigned wesbillman and unassigned worstell May 2, 2024
@worstell
Copy link
Contributor

worstell commented May 2, 2024

related: #1381

@alecthomas alecthomas assigned alecthomas and unassigned wesbillman May 11, 2024
alecthomas added a commit that referenced this issue May 11, 2024
@alecthomas
fix: vastly improve development responsiveness and startup time
89c7eb4 
There are two changes that contribute to this improvement:

1. Reduce most task reschedule timers to 1s.
2. Decrease runner/controller heartbeats to 1s.
3. Clear all transient database rows that slow down restarts - leases,
   runner/controller locks, etc.

Fixes #1010
Fixes #1381
alecthomas added a commit that referenced this issue May 11, 2024
@alecthomas
fix: vastly improve development responsiveness and startup time
c2e7576 
There are two changes that contribute to this improvement:

1. Reduce most task reschedule timers to 1s.
2. Decrease runner/controller heartbeats to 1s.
3. Clear all transient database rows that slow down restarts - leases,
   runner/controller locks, etc.

Fixes #1010
Fixes #1381
@alecthomas alecthomas mentioned this issue May 11, 2024
Merged
alecthomas added a commit that referenced this issue May 11, 2024
@alecthomas
fix: vastly improve development responsiveness and startup time
ecbd466 
There are two changes that contribute to this improvement:

1. Reduce most task reschedule timers to 1s.
2. Decrease runner/controller heartbeats to 1s.
3. Clear all transient database rows that slow down restarts - leases,
   runner/controller locks, etc.

Fixes #1010
Fixes #1381
alecthomas added a commit that referenced this issue May 11, 2024
@alecthomas
fix: vastly improve development responsiveness and startup time (#1465)
c584822 
There are two changes that contribute to this improvement:

1. Reduce most task reschedule timers to 1s.
2. Decrease runner/controller heartbeats to 1s.
3. Clear all transient database rows that slow down restarts - leases,
runner/controller locks, etc.

Fixes #1010
Fixes #1381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alecthomas alecthomas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@alecthomas @wesbillman @worstell