chore: decrease devel startup/reconciliation time #1278
Merged
+45
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
worstell
force-pushed
the
worstell/20240416-decrease-devel-startup-time
branch
from
44b3b4f to
20d78b8
Compare
wesbillman
reviewed
Apr 16, 2024
backend/controller/controller.go
Outdated
Comment on lines
213
to
221
| func (s *Service) scheduleDevelopmentTasks() { | ||
| s.tasks.Parallel(backoff.Backoff{Min: time.Second, Max: time.Second}, s.syncRoutes) | ||
| s.tasks.Parallel(backoff.Backoff{Min: time.Second * 2, Max: time.Second * 2}, s.heartbeatController) | ||
| s.tasks.Parallel(backoff.Backoff{Min: time.Second, Max: time.Second}, s.updateControllersList) | ||
| s.tasks.Singleton(backoff.Backoff{Min: time.Second, Max: time.Second}, s.reapStaleRunners) | ||
| s.tasks.Singleton(backoff.Backoff{Min: time.Second, Max: time.Second}, s.releaseExpiredReservations) | ||
| s.tasks.Singleton(backoff.Backoff{Min: time.Second, Max: time.Second}, s.reconcileDeployments) | ||
| s.tasks.Singleton(backoff.Backoff{Min: time.Second, Max: time.Second}, s.reconcileRunners) | ||
| s.tasks.Parallel(backoff.Backoff{Min: time.Second, Max: time.Second}, s.reapStaleControllers) |
There was a problem hiding this comment.
Nice! This will be much better :)
Is there a way to refactor this so only the Max time value is changed? vs. having to duplicate all these tasks? My concern would be that we might add a task to dev and forget to add it to prod or visa versa
There was a problem hiding this comment.
good point - will refactor so we don't need to maintain separate lists
worstell
force-pushed
the
worstell/20240416-decrease-devel-startup-time
branch
from
20d78b8 to
1d84771
Compare
worstell
force-pushed
the
worstell/20240416-decrease-devel-startup-time
branch
from
1d84771 to
327d47a
Compare
wesbillman
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1010