Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vastly improve development responsiveness and startup time #1465

Merged
merged 1 commit into from
May 11, 2024
Merged

fix: vastly improve development responsiveness and startup time #1465

merged 1 commit into from
May 11, 2024

Conversation

alecthomas
Copy link
Collaborator

There are two changes that contribute to this improvement:

  1. Reduce most task reschedule timers to 1s.
  2. Decrease runner/controller heartbeats to 1s.
  3. Clear all transient database rows that slow down restarts - leases, runner/controller locks, etc.

Fixes #1010
Fixes #1381

@alecthomas alecthomas requested review from a team and matt2e and removed request for a team May 11, 2024 03:54
@alecthomas
fix: vastly improve development responsiveness and startup time
ecbd466 
There are two changes that contribute to this improvement:

1. Reduce most task reschedule timers to 1s.
2. Decrease runner/controller heartbeats to 1s.
3. Clear all transient database rows that slow down restarts - leases,
   runner/controller locks, etc.

Fixes #1010
Fixes #1381
@alecthomas alecthomas force-pushed the aat/fast-devel-startup branch from c2e7576 to ecbd466 Compare May 11, 2024 03:54
@alecthomas alecthomas enabled auto-merge (squash) May 11, 2024 03:55
@alecthomas alecthomas mentioned this pull request May 11, 2024
Open
@alecthomas alecthomas merged commit c584822 into main May 11, 2024
10 checks passed
@alecthomas alecthomas deleted the aat/fast-devel-startup branch May 11, 2024 03:57
@wesbillman
Copy link
Collaborator

Dude!!! This is awesome 🥳

@matt2e
Copy link
Collaborator

matt2e commented May 12, 2024

yeh nice!

@matt2e matt2e added the approved Marks an already closed PR as approved label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt2e matt2e Awaiting requested review from matt2e

Assignees
No one assigned
Labels
approved Marks an already closed PR as approved
Projects
None yet
Milestone
No milestone
3 participants
@alecthomas @wesbillman @matt2e