Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruff: drop use of .ruff.toml #1217

Merged
merged 2 commits into from
Nov 20, 2024
Merged

ruff: drop use of .ruff.toml #1217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abcc0c2
ruff: drop use of .ruff.toml
bjlittle Nov 20, 2024
5b5b650
add changelog news fragment
bjlittle Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .ruff.toml
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ exclude .all-contributorsrc
exclude .gitignore
exclude .pre-commit-config.yaml
exclude .readthedocs.yml
exclude .ruff.toml
include *.md
exclude CHANGELOG.rst
include CITATION.cff
Expand Down
4 changes: 4 additions & 0 deletions changelog/1217.contributor.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Dropped the use of ``.ruff.toml`` to capture outstanding
`ruff <https://github.com/astral-sh/ruff>`__ rule exceptions. Non-compliances
have been addressed or moved to the ``pyproject.toml``.
(:user:`bjlittle`)
7 changes: 5 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,6 @@ preview = false
# Allow information-source (U+2139) which could be confused for "i".
allowed-confusables = ["ℹ"]
ignore = [
# NOTE: Non-permanent exclusions should be added to ".ruff.toml".

# flake8-annotations (ANN)
# https://docs.astral.sh/ruff/rules/#flake8-annotations-ann
"ANN101", # Missing type annotation for 'self' in method.
Expand Down Expand Up @@ -264,6 +262,11 @@ max-statements = 91
# https://docs.astral.sh/ruff/rules/#flake8-boolean-trap-fbt
"FBT001", # flake8-boolean-trap: Boolean-typed positional argument in function definition.
]
# TODO @bjlittle: resolve use of typing.Any
"src/geovista/geoplotter.py" = [
# https://docs.astral.sh/ruff/rules/#flake8-annotations-ann
"ANN401", # flake8-annotations: Dynamically typed expressions (typing.Any).
]
"test_*.py" = [
# flake8-annotations (ANN)
# https://docs.astral.sh/ruff/rules/#flake8-annotations-ann
Expand Down
Loading