Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the default value for isSlate field per Conviva documentation #84

Merged
merged 3 commits into from
Oct 27, 2024
Merged

Added the default value for isSlate field per Conviva documentation #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4b3d59
added default value for isSlate per Conviva docs
saravanans-github Oct 22, 2024
9b899c1
added feature to ChangeLog
saravanans-github Oct 22, 2024
484823f
Update CHANGELOG.md
saravanans-github Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

### Added
- Default value of `false` for `c3.ad.isSlate` for client side ad insertion per Conviva Custom Ad Manager integration docs

## 2.7.1 - 2024-09-24
### Fixed
- Reporting wrong ad position for mid-roll VMAP ads
Expand Down
3 changes: 3 additions & 0 deletions conviva/src/main/java/com/bitmovin/analytics/conviva/ConvivaAnalyticsIntegration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,6 +794,9 @@ private Map<String, Object> adStartedToAdInfo(PlayerEvent.AdStarted adStartedEve
adInfo.put(ConvivaSdkConstants.FRAMEWORK_VERSION, Player.getSdkVersion());
}

// default value for isSlate is false for Custom Ad Manager integration
adInfo.put("c3.ad.isSlate", "false");

double scheduleTime;
if (activeAdBreak != null) {
scheduleTime = activeAdBreak.getScheduleTime();
Expand Down