Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the default value for isSlate field per Conviva documentation #84

Merged
merged 3 commits into from
Oct 27, 2024

Conversation

saravanans-github
Copy link
Contributor

added a default value of false for c3.ad.isSlate in adStartedToAdInfo method.

Conviva documentation reference - https://pulse.conviva.com/learning-center/content/sensor_developer_center/sensor_integration/android/android_quick_integration.htm

Please see highlighted text in screenshot.
Screenshot 2024-10-22 at 5 37 12 PM

Copy link
Contributor

@strangesource strangesource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Thanks for the PR.
Having some unit tests would be great in case you have time, you could have a look at

for inspiration.

CHANGELOG.md Outdated Show resolved Hide resolved
updated per suggestion

Co-authored-by: Lukas Knoch-Girstmair <[email protected]>
@saravanans-github saravanans-github merged commit a86294a into develop Oct 27, 2024
3 checks passed
@saravanans-github saravanans-github deleted the feat/isSlateField branch October 27, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants