Fixing the CLN feature bit parsing #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr-gi
reviewed
Dec 4, 2024
simln-lib/src/cln.rs
Outdated
Comment on lines
91
to
92
| features.node.reverse(); | ||
| NodeFeatures::from_le_bytes(features.node) |
There was a problem hiding this comment.
You should be able to use NodeFeatures::from_be_bytes if I'm not mistaken. I PRd a change to make that public on LDK a while ago but it looks like we forgot to apply the changes downstream
There was a problem hiding this comment.
Ah even better. I will switch both calls to use from_be_bytes. Thanks!
…e bytes before parsing
bjohnson5
force-pushed
the
208-feature-bits-fix
branch
from
b696eff to
5f802c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #208 by flipping the feature bits before parsing them.