Merge pull request #209 from bjohnson5/208-feature-bits-fix

Fixing the CLN feature bit parsing
bitcoin-dev-project · Dec 18, 2024 · 8834888 · 8834888
2 parents 4d33f24 + 5f802c9
commit 8834888
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/simln-lib/src/cln.rs b/simln-lib/src/cln.rs
@@ -88,7 +88,7 @@ impl ClnNode {
         connection.id.validate(&pubkey, &mut alias)?;
 
         let features = if let Some(features) = our_features {
-            NodeFeatures::from_le_bytes(features.node)
+            NodeFeatures::from_be_bytes(features.node)
         } else {
             NodeFeatures::empty()
         };
@@ -248,11 +248,7 @@ impl LightningNode for ClnNode {
                 features: node
                     .features
                     .clone()
-                    .map_or(NodeFeatures::empty(), |mut f| {
-                        // We need to reverse this given it has the CLN wire encoding which is BE
-                        f.reverse();
-                        NodeFeatures::from_le_bytes(f)
-                    }),
+                    .map_or(NodeFeatures::empty(), NodeFeatures::from_be_bytes),
             })
         } else {
             Err(LightningError::GetNodeInfoError(