Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexing on get_allostery #470

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Fix indexing on get_allostery #470

merged 1 commit into from
Jul 18, 2024

Conversation

carrascomj
Copy link
Member

get_allostery was wrong in the indexing of free enzyme ration, same as vmax was before.

Would be good to have an example with N_edge > N_enzyme (with drains) to test for this cases.

Checklist:

  • Updated any relevant documentation
  • Add an adr doc if appropriate
  • Include links to any relevant issues in the description
  • Unit tests passing
  • Integration tests passing

@teddygroves
Copy link
Member

Nice catch!

@teddygroves teddygroves merged commit 094d460 into main Jul 18, 2024
5 of 6 checks passed
@carrascomj carrascomj mentioned this pull request Aug 15, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants