New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating `jsonlines` dependecy version. #480

Merged

caufieldjh merged 2 commits into master from jsonlines-update

Mar 26, 2024

Collaborator

hrshdhgd commented Mar 25, 2024 •

edited

Loading

Reason:

ODK:
- kgx and oaklib are dependencies.
- oaklib happens to use ^4.0.0 and kgx has it at ^3.1.0 (which implies (<4.0.0). Because of this the dependencies do not get resolved and:
  - poetry complains
  - ODK uses requirements.txt which autogenerates constraints.txt which basically anchors package versions to exact x.x.x . Due to this kgx version that gets installed is 1.7.2. I don't know why or how (my naive guess is jsonlines was not a dependency for that version?)
  - This PR is my test to see if this is the reason plus it doesn't hurt to update a package if it doesn't break anything.


          Updating jsonlines dependecy version.

d06e406

hrshdhgd requested a review from sierra-moxon

March 25, 2024 20:01


          Ordering dep list

1c4b66f

Collaborator

caufieldjh commented Mar 26, 2024

Should be fine. Newer version of jsonlines doesn't support Python 3.7 but we're already requiring 3.9 or above for kgx, so no issues there.

caufieldjh merged commit 8e59816 into master

2 checks passed

caufieldjh deleted the jsonlines-update branch

March 26, 2024 14:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet