Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] DiscreteVariable reconstruction #3242

Merged
merged 4 commits into from
Sep 12, 2018
Merged

[FIX] DiscreteVariable reconstruction #3242

merged 4 commits into from
Sep 12, 2018

Commits on Sep 11, 2018

  1. Variable: Return proxies from DiscreteVariable.make 

    As already done in biolabgh-2667 for other variables.
    @ales-erjavec
    ales-erjavec committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    c18f757 View commit details
    Browse the repository at this point in the history

  2. Variable: Ensure .values are preserved exactly on deserialization 

    This is done to ensure any indices into the `values` list, that are
serialized alongside the variable, retain their meaning.
    @ales-erjavec
    ales-erjavec committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    5552339 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2018

  1. Varaible: Add test for unpickling DiscreteVariable

    @ales-erjavec
    ales-erjavec committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    e0a0b02 View commit details
    Browse the repository at this point in the history

  2. Varaible: Fix failing 'test_make_proxy_disc' test 

    The test fails due to the DiscreteVariable.make returning proxies
    @ales-erjavec
    ales-erjavec committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    f780bd4 View commit details
    Browse the repository at this point in the history