[FIX] DiscreteVariable reconstruction #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As already done in biolabgh-2667 for other variables.
This is done to ensure any indices into the `values` list, that are serialized alongside the variable, retain their meaning.
The test fails due to the DiscreteVariable.make returning proxies
lanzagar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes gh-3238
Description of changes
Return proxies from DiscreteVariable.make (as already done in [FIX] Variable.make returns proxies #2667 for other variables)
Ensure
var.valuesare preserved exactly on deserialization, even at the expanse of variable 'equality'. This is done to ensure any indices into thevalueslist, that are serialized alongside the variable, retain their meaning.Includes