Add support for single end data and switch to python3 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nictru , thanks a lot for the helpful PR. There may be some concerns about the code for identifying single-ended / paired-ended BSJ reads. I will look into this, but maybe not very soon. Once done, I will be very happy to merge these codes into the next release. |
|
Maybe I can perform an evaluation similar to the one in the paper on single-stranded data to increase confidence |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
First of all, thanks for the fantastic package. This PR contains the changes mentioned in the title. Both did not require a lot of code changes.
Updating to python3 allows using current versions of various dependencies. It also helps overcome some problems with bundling for bioconda (related PR).
Adding support for single-stranded datasets allows wider usage of the package. I understand that this needs to be thoroughly evaluated before it can make it into production.
If you are interested in adding these changes to the package, I am eager to contribute. If not, I will most likely keep maintaining a fork, as these functionalities are important for my use case.