Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

feat(checkout): CHECKOUT-7899 Update docs of s2s cart api to allow passing source #1546

Closed
wants to merge 1 commit into from
Closed

feat(checkout): CHECKOUT-7899 Update docs of s2s cart api to allow passing source #1546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions reference/carts.v3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,6 +1134,11 @@ components:
description: 'The locale of the cart. Accepts strings of format `xx` or `xx-YY`. Uses the [ISO-639 standard](https://www.iso.org/iso-639-language-codes.html) format.'
format: ISO-639
example: en-US
source:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to expose this publicly / allow developer to call V3 to create Manual Order directly?
I think this will be used by CP only so maybe we don't need to document it for now.

Also I would say it can be confusing to have this in the doc as we don't want people to believe they need to send the source on every requests, especially if we say we only accept MANUAL_INCOMPLETE.

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that makes sense. I think again, that keep this a secret now should not cause any issue.

type: string
description: the source of the cart. client can explicitly pass the source of the cart
enum:
- MANUAL_INCOMPLETE
description: ''
CartRequestData:
type: object
Expand Down
Loading